Expose explorer types to ease development of library's consumer.#24
Open
benjaminbours wants to merge 2 commits intopinknetworkx:masterfrom
Open
Expose explorer types to ease development of library's consumer.#24benjaminbours wants to merge 2 commits intopinknetworkx:masterfrom
benjaminbours wants to merge 2 commits intopinknetworkx:masterfrom
Conversation
Author
|
@fabian-emilius I realised some types are also incomplete, so in addition to expose them, I am also completing them.
|
Author
|
@fabian-emilius any update about it? Its really small stuff, it takes only a minute to review this change. |
Author
|
@fabian-emilius? Would like other people to come and help you maintain this repo? I can give you a hand if you allow me to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@fabian-emilius if you can validate this, could be awesome 🙏 Just a small things to expose Typescript types and allow library consumers to build strong typed code around the lib.